Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the 'twentytwentyfour' test theme dir created by wp-env #59072

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Ignore the 'twentytwentyfour' test theme dir created by wp-env #59072

merged 1 commit into from
Feb 15, 2024

Conversation

Mamaduka
Copy link
Member

What?

This is similar to #53031.

Adds twentytwentyfour theme to the ignored test theme list.

Why?

→ warning: failed to remove test/gutenberg-test-themes/twentytwentyfour/: Permission denied

Testing Instructions

  • Run npx wp-env start --update - you should see twentytwentyfour downloaded and installed as per this config.
  • Confirm that the above theme folders have been created inside /test/gutenberg-test-themes/ folder (they should be empty).
  • Make any change to any file and try to commit it - you should be able to do this without the aforementioned issue on this branch and not on trunk.

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Feb 15, 2024
@Mamaduka Mamaduka self-assigned this Feb 15, 2024
@draganescu
Copy link
Contributor

curious this didn't show in git status

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: draganescu <andraganescu@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

draganescu
draganescu approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@draganescu draganescu enabled auto-merge (squash) February 15, 2024 12:10
@github-actions GitHub Actions
Copy link

Flaky tests detected in 33aed3d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7915630700
📝 Reported issues:

@draganescu draganescu merged commit 2349114 into trunk Feb 15, 2024
61 checks passed
@draganescu draganescu deleted the fix/test-themes-dir-permissions branch February 15, 2024 12:41
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 15, 2024
@youknowriad
Copy link
Contributor

@Mamaduka I think you forgot the props bot :P

@Mamaduka
Copy link
Member Author

Props bot, blame @draganescu :D

@draganescu
Copy link
Contributor

I did paste the props bot thing and then enabled automerge.

@youknowriad
Copy link
Contributor

You just lost a prop @draganescu :P just blame yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@WunderBart WunderBart Awaiting requested review from WunderBart

Assignees

@Mamaduka Mamaduka

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @draganescu @youknowriad